-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Knowit not suited for pickling #15
Comments
One of the issues I have with the knowit results, is that the reporter is using different object reported by different providers. It would be really nice if this could be standardized. Any reason why this hasn't been done? |
I still didn't get the different object reported by different providers |
Check this: https://github.com/pymedusa/Medusa/pull/5135/files#diff-8dae95e92447489197bc2654f723edaeR106. You see that I already encode a number of non-pickable object types. Like for example I didn't make these up. I had to add them by trial an error. And it worked to some degree. Unfortunately, i'm digging into something else right now. And this didn't have a very high prio for me at the time. |
no_units is an option that's available since long time. That will get rid of pint Quantity |
Fixed by c9b7177 |
Aah thx. Then we can start dogpile cache the knowit results. |
Hi @ratoaq2
I'm having issues dogpiling knowit results, because it has al kinds of non-pickable objects, like datetime, Quantity, etc.
I'm currenlty trying dogpile with msgpack writing my own encoders. But it's really a hassle.
What would be your approach here?
The text was updated successfully, but these errors were encountered: