src/bundle: remove signature size sanity check #1316
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Historically, checking that the signature size is smaller than the bundle size was a sensible test. However, with the added support for encrypted bundles, we may run in cases where the bundle size is actually smaller than the signature size. This happens because the CMS structure holds the individual recipients for encrypted bundles and with having thousands of recipients, the CMS structure size can reach a notable size. If that's combined with a quite small update image, the sanity check can be triggered and prevents from installing such a bundle. Since this is just a sanity check, since we have other sanity checks and since we intend to support large amounts of encryption recipients, simply remove the sanity check. Fixes rauc#1308. Signed-off-by: Enrico Joerns <ejo@pengutronix.de>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1316 +/- ##
==========================================
+ Coverage 80.21% 80.23% +0.02%
==========================================
Files 67 67
Lines 19980 19972 -8
==========================================
- Hits 16026 16024 -2
+ Misses 3954 3948 -6 ☔ View full report in Codecov by Sentry. |
|
The check compares the signature size against the complete bundle size, not only the payload size as I initially thought. And the complete bundle size (which includes the signature) should, of course, always be smaller than just the signature size. So there is no reason to remove the check. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Historically, checking that the signature size is smaller than the bundle size was a sensible test.
However, with the added support for encrypted bundles, we may run in cases where the bundle size is actually smaller than the signature size. This happens because the CMS structure holds the individual recipients for encrypted bundles and with having thousands of recipients, the CMS structure size can reach a notable size. If that's combined with a quite small update image, the sanity check can be triggered and prevents from installing such a bundle.
Since this is just a sanity check, since we have other sanity checks and since we intend to support large amounts of encryption recipients, simply remove the sanity check.
Fixes #1308.