Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim diffed HTML and improve serializer test. #17

Merged
merged 2 commits into from Apr 23, 2019
Merged

Trim diffed HTML and improve serializer test. #17

merged 2 commits into from Apr 23, 2019

Conversation

scotthovestadt
Copy link
Contributor

This PR resolves two issues:

  1. Currently, the snapshot has an extra newline on the top and bottom. This especially looks ugly with (new and improved!) inline snapshots. I resolve it in this PR with a simple trim().
  2. Also check to be sure any possible HTML string ends with >.

rayrutjes
rayrutjes reviewed Apr 14, 2019
View reviewed changes
Copy link
Member

@rayrutjes rayrutjes left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me, thanks for the contribution.

Do you mind renaming the commit so as to respect the conventional commit format?

See an example commit here: #12

This allows me to easily and lazily generate the changelog.

@scotthovestadt
Copy link
Contributor Author

@rayrutjes Is it possible for you to use GitHub's "Squash and Merge" to lump the commits together and rename them to your preference?

https://help.github.com/en/articles/configuring-commit-squashing-for-pull-requests

Let me know if not and I'll just recreate the PR.

@scotthovestadt
Copy link
Contributor Author

Ping. :)

@rayrutjes rayrutjes merged commit aa47789 into algolia:master Apr 23, 2019
@rayrutjes rayrutjes mentioned this pull request Apr 28, 2019
Closed
@rayrutjes
Copy link
Member

@scotthovestadt now released under v7.0.0.

Thanks for your patience.

@scotthovestadt
Copy link
Contributor Author

@rayrutjes 🎉Thank you! 🎉

@ylemkimon ylemkimon mentioned this pull request Jul 12, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rayrutjes rayrutjes rayrutjes approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@scotthovestadt @rayrutjes