Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Menu button inside a dialog takes 2 clicks to open #862

Closed
honestbonsai opened this issue Nov 3, 2021 · 2 comments
Closed

Menu button inside a dialog takes 2 clicks to open #862

honestbonsai opened this issue Nov 3, 2021 · 2 comments

Comments

@honestbonsai
Copy link

honestbonsai commented Nov 3, 2021

馃悰 Bug report

Current Behavior

Using a MenuButton in a Dialog needs 2 clicks to open the menu.

I have a MenuButton not in a Dialog and it works as expected with a single click.

Expected behavior

It should only take 1 click.

Additional context

Might be related to #830 and #808

Your environment

Software Name(s) Version
Reach Package @reach/menu-button 0.16.1
Reach Package @reach/dialog 0.16.0
React 17.0.1
Browser Chrome
Node 16.1.0
npm/yarn 1.22.10
Operating System Mac 11.6
@honestbonsai
Copy link
Author

On further investigation, it seems like this was resolved in #808. Just the official docs haven't been updated. For anyone with the same issue, you can look at: https://github.com/reach/reach-ui/blob/develop/packages/menu-button/examples/inside-dialog.example.tsx

@YauheniKhadanionak
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants