Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(slider): prevent keyboard events when disabled #583

Merged
merged 1 commit into from Jun 12, 2020

Conversation

raunofreiberg
Copy link
Contributor

Closes #582

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 9476523:

Sandbox Source
dawn-paper-mvvyh Configuration

@chaance chaance added Status: Investigation Type: Bug Something isn't working labels May 24, 2020
@chaance chaance merged commit 4451d4c into reach:master Jun 12, 2020
@raunofreiberg raunofreiberg deleted the fix/slider-disabled branch July 1, 2020 08:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Investigation Type: Bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Slider] keyboard can still change value when Slider disabled and handle is focused
2 participants