Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(website): remove redundant :root selector in app.scss of website #585

Merged
merged 1 commit into from May 20, 2020
Merged

fix(website): remove redundant :root selector in app.scss of website #585

merged 1 commit into from May 20, 2020

Conversation

abhishekjakhar
Copy link
Contributor

@abhishekjakhar abhishekjakhar commented May 13, 2020

The :root selector was repeated twice in app.scss file of reach website, one of them have been removed


Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

@abhishekjakhar abhishekjakhar changed the title Remove redundant :root selector in app.scss of website fix: remove redundant :root selector in app.scss of website May 13, 2020
@abhishekjakhar abhishekjakhar changed the title fix: remove redundant :root selector in app.scss of website fix(website): remove redundant :root selector in app.scss of website May 13, 2020
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 791a8b4:

Sandbox Source
focused-roentgen-oy68e Configuration

@abhishekjakhar
Copy link
Contributor Author

I don't think build is failing because of my change.

@chaance chaance added the Type: Documentation Changes to the docs label May 20, 2020
@chaance chaance merged commit c87d776 into reach:website May 20, 2020
@abhishekjakhar
Copy link
Contributor Author

@chancestrickland any idea why build is failing? I created a PR against the website branch, do I need to create PR against the master?

@chaance
Copy link
Member

chaance commented May 20, 2020

Yeah, the website branch was out-of-date with master and there were some unresolved dependency issues. We're good now, thanks! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Changes to the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants