fix(build): dont use Array.flatMap
#588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 3805ad4:
|
raunofreiberg
changed the title
Array.flatMap
raunofreiberg
commented
May 18, 2020
| @@ -267,10 +268,10 @@ function createConfigItems(type: any, items: any[]) { | |||
| function mergeConfigItems(type: any, ...configItemsToMerge: any[]) { | |||
| const mergedItems: any[] = []; | |||
|
|
|||
| configItemsToMerge.forEach(configItemToMerge => { | |||
| configItemsToMerge.forEach((configItemToMerge) => { | |||
There was a problem hiding this comment.
thanks prettier
|
Yay! The components now work per CodeSandbox build: https://codesandbox.io/s/dark-cloud-m46tz |
raunofreiberg
force-pushed
the
fix/codesandbox-ci-build
branch
from
d48a669
to
3805ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.
yarn test).yarn start).This pull request:
Closes #586
I figured it's probably more straightforward to just drop
Array.flatMapfor now. We could instead check for'flatMap' in Arrayas well, but I don't see the point.