Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix tabs.mdx animated example #597

Merged
merged 1 commit into from May 24, 2020
Merged

Fix tabs.mdx animated example #597

merged 1 commit into from May 24, 2020

Conversation

homburg
Copy link
Contributor

@homburg homburg commented May 21, 2020

useRect is relative to viewport, but absolute positioning is relative to containing block. Compensate by using the difference.

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

  • Use a meaningful title for the pull request. Include the name of the package modified.
  • Test the change in your own code (Compile and run).
  • Add or edit tests to reflect the change (Run with yarn test).
  • Add or edit Storybook examples to reflect the change (Run with yarn start).
  • Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

  • Creates a new package
  • Fixes a bug in an existing package
  • Adds additional features/functionality to an existing package
  • Updates documentation or example code
  • Other

If creating a new package:

  • Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
    • examples directory
    • src directory with an index.tsx entry file
    • At least one example file per feature introduced by the new package
    • Base styles in a style.css file (if needed by the new package)

Before / after

Screen Recording 2020-05-21 at 09 55 AM

Screen Recording 2020-05-21 at 09 52 AM

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit fe26df3:

Sandbox Source
eloquent-beaver-on7zs Configuration

@chaance chaance changed the base branch from master to website May 24, 2020 15:21
@chaance chaance added the Type: Documentation Changes to the docs label May 24, 2020
@chaance chaance merged commit a500c59 into reach:website May 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Documentation Changes to the docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants