[popover] Fix stuck focus

[michaeldfoley]

When the targetRef is the last tabbable element outside the popover, getElementAfterTrigger returns the first tabbable element inside the portal causing the focus to stay trapped inside the popover. What we want is for getElementAfterTrigger to return an element only if it is not inside the popover.

Thank you for contributing to Reach UI! Please fill in this template before submitting your PR to help us process your request more quickly.

• Use a meaningful title for the pull request. Include the name of the package modified.
• Test the change in your own code (Compile and run).
• Add or edit tests to reflect the change (Run with yarn test).
• Add or edit Storybook examples to reflect the change (Run with yarn start).
• Ensure formatting is consistent with the project's Prettier configuration.

This pull request:

• Creates a new package
• Fixes a bug in an existing package
• Adds additional features/functionality to an existing package
• Updates documentation or example code
• Other

If creating a new package:

• Make sure the new package directory contains each of the following, and that their structure/formatting mirrors other related examples in the project:
  • examples directory
  • src directory with an index.tsx entry file
  • At least one example file per feature introduced by the new package
  • Base styles in a style.css file (if needed by the new package)

[codesandbox-ci]

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b656d2b:

Sandbox	Source
laughing-chatterjee-hube6	Configuration

[chaance]

@michaeldfoley Can you reproduce a test case using the CodeSandbox link generated above? I'm happy to merge this if I can get a better understanding of the problem with a simple example.

[michaeldfoley]

In this example the focus gets stuck in the popover when there are no tabbable items after the targetRef.

Here is the same example with my PR applied. After the popup, the focus moves into the chrome as expected.

[chaance]

Looks good to me, thank you!