Skip to content

Latest commit

 

History

History
83 lines (55 loc) · 2.56 KB

remove.md

File metadata and controls

83 lines (55 loc) · 2.56 KB

Removing redux-saga

We don't recommend removing redux-saga, as we strongly feel that it's the way to go for most redux based applications.

If you really want to get rid of it, you will have to remove its presence from several places.

app/configureStore.js

  1. Remove statement import createSagaMiddleware from 'redux-saga'.
  2. Remove statement const sagaMiddleware = createSagaMiddleware().
  3. Remove sagaMiddleware from middlewares array.
  4. Remove statement store.runSaga = sagaMiddleware.run
  5. Remove store.injectedSagas = {}; // Saga registry

app/tests/store.test.js

  1. Remove describe block and tests for injectSagas
  2. Remove describe block and tests for runSaga

app/utils

  1. Remove three files: injectSaga.js, sagaInjectors.js, and constants.js.

app/utils/checkStore.js

  1. Remove runSaga: isFunction,
  2. Remove injectedSagas: isObject,

app/utils/tests

  1. Remove two files: injectSaga.test.js and sagaInjectors.test.js

app/utils/tests/checkStore.test.js

  1. Remove expect(() => checkStore({ ...store, injectedSagas: null })).toThrow();
  2. Remove expect(() => checkStore({ ...store, runSaga: null })).toThrow();

app/containers/*/index.js

Clean up containers that inject a dynamic saga

  1. Remove saga injections like: const withSaga = injectSaga({ key: 'home', saga });.

Finally, remove it from the package.json. Then you should be good to go with whatever side-effect management library you want to use!

  1. Remove redux-saga from dependencies
  2. Remove eslint-plugin-redux-saga from devDependencies
  3. Remove eslintConfig > plugins > redux-saga
  4. Remove eslintConfig > rules > redux-saga/*

Removing reselect

To remove reselect, remove it from your dependencies in package.json and then write your mapStateToProps functions like you normally would!

You'll also need to hook up the history directly to the store. Make changes to app/app.js.

  1. Remove statement import { makeSelectLocationState } from 'containers/App/selectors'
  2. Make necessary changes to history as follows:
const makeSelectLocationState = () => {
  let prevRoutingState;
  let prevRoutingStateJS;

  return state => {
    const routingState = state.get('router'); // or state.route

    if (!routingState.equals(prevRoutingState)) {
      prevRoutingState = routingState;
      prevRoutingStateJS = routingState.toJS();
    }

    return prevRoutingStateJS;
  };
};

const history = syncHistoryWithStore(browserHistory, store, {
  selectLocationState: makeSelectLocationState(),
});