fix(Popover): arrow offset when scrolling offscreen #5287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
taion
approved these changes
Jul 10, 2020
taion
reviewed
Jul 10, 2020
| !overlayRef.current || | ||
| !state.elements.arrow || | ||
| !hasClass(overlayRef.current, 'popover') || | ||
| !state.modifiersData['arrow#persistent'] |
There was a problem hiding this comment.
question: where does #persistent come from? is this really an id?
There was a problem hiding this comment.
its a special key Popper adds, nothing unique about it tho aside from Popper picked it
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on the react overlays bump.
this still doesn't cover this problem floating-ui/react-popper#375 but at least it won't lock up and crash