Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document must have one main landmark and a All page content must be contained by landmarks in Axe validator when creating a modal #5527

Closed
jcmontoyar opened this issue Nov 17, 2020 · 1 comment · Fixed by #5529

Comments

@jcmontoyar
Copy link

Describe the bug

When creating a modal with react bootstrap the axe valitator shows both issues in the title.

To Reproduce

Steps to reproduce the behavior:

  1. Create any modal or just go to the modal component in the react documentation
  2. Inspect element in google chrome
  3. Run axios validator
  4. Both issues will appear

Environment (please complete the following information)

  • Operating System: windows 10
  • Browser, Version [e.g. Chrome 86]
  • React-Bootstrap Version 1.4.0
@kyletsang
Copy link
Member

Looks like upstream bootstrap has removed role="document" from the modal in twbs/bootstrap#30687. We should do the same here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants