feat(Tabs): Added possibility of passing custom attributes to Tab com… #5879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
How do we get an approver for this? This fix will save me the work of building my own tab control (so I can instrument the control with a Cypress tag for automated testing) |
kyletsang
approved these changes
Feb 5, 2022
|
Looks alright to me. @jquense did you want to double check? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…ponent
Resolves: #5644
<Tab />can now receivetabAttrsobject which will be passed to underlying navlink component as attributes wherekeyis the name of attribute andvalueis it's value