fix: prioritize poppers position prop in overlaytrigger #6175
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kyletsang
reviewed
Jan 6, 2022
src/Overlay.tsx
Outdated
| @@ -181,18 +181,20 @@ const Overlay = React.forwardRef<HTMLElement, OverlayProps>( | |||
| > | |||
| {(overlayProps, { arrowProps, placement, popper: popperObj, show }) => { | |||
| wrapRefs(overlayProps, arrowProps); | |||
| // Need to get placement from popper object first, handling case when overlay is flipped using 'flip' prop | |||
| const updatedPlacement = popperObj?.placement || placement; | |||
There was a problem hiding this comment.
Hmm I wonder if we need to fallback to placement here.
I think(?) popper's placement should always be defined.
I think this might be enough const updatedPlacement = popperObj?.placement;
There was a problem hiding this comment.
i think you're right, will change
kyletsang
approved these changes
Jan 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6173. What was happening is that
placementprop was being passed toBaseOverlayand then passed to theoverlayprop, ignoring popper object, which in turn resulted in hard-coded theplacementproperty