Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added missing exports. #6228

Merged
merged 11 commits into from Feb 4, 2022
Merged

Conversation

VibhorJaiswal
Copy link
Contributor

@VibhorJaiswal VibhorJaiswal commented Feb 2, 2022

fixes: #6226

@VibhorJaiswal VibhorJaiswal marked this pull request as draft February 2, 2022 15:25
@VibhorJaiswal VibhorJaiswal marked this pull request as ready for review February 2, 2022 15:35
Copy link
Collaborator

@golota60 golota60 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@VibhorJaiswal VibhorJaiswal marked this pull request as draft February 3, 2022 14:51
@VibhorJaiswal
Copy link
Contributor Author

I have also converted ModalBody, ModalFooter, ModalHeader and ModalTitle to rtl.

@VibhorJaiswal VibhorJaiswal marked this pull request as ready for review February 3, 2022 14:55
@golota60
Copy link
Collaborator

golota60 commented Feb 3, 2022

@VibhorJaiswal Nice! 👍 Could you make a separate PR for testing-related changes?
It'll make it easier to code review & merge those

@VibhorJaiswal
Copy link
Contributor Author

@golota60 okay.

@VibhorJaiswal VibhorJaiswal marked this pull request as draft February 3, 2022 15:59
@kyletsang
Copy link
Member

We don't need to expose ModalContext in the index. Consumers don't need to use this

@VibhorJaiswal VibhorJaiswal marked this pull request as ready for review February 4, 2022 14:21
@kyletsang kyletsang merged commit 3332da9 into react-bootstrap:master Feb 4, 2022
@kyletsang
Copy link
Member

Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing export for ModalHeader
3 participants