feat: support custom breakpoints #6253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lindapaiste
reviewed
Feb 23, 2022
| @@ -36,9 +36,9 @@ export interface ColProps | |||
| lg?: ColSpec; | |||
| xl?: ColSpec; | |||
| xxl?: ColSpec; | |||
| [key: string]: any; | |||
There was a problem hiding this comment.
This is rough -- [key: string]: any allows pretty much any prop. But I don't think there's any good way to avoid it. These are top-level properties so [key: string]: ColSpec would produce an incompatible index signature error.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #6247
Loosens the types for any breakpoint-related prop so it takes in any string. For the components that use a hard coded breakpoint list, I've allowed the user to specify their own list of breakpoints in the ThemeProvider so these components can take advantage of it.
Haven't added docs yet. Wanted to make sure the approach looks good before doing so.