Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useOverlayOffset): use offset prop in useOverlayOffset #6264

Merged
merged 3 commits into from Mar 10, 2022
Merged

fix(useOverlayOffset): use offset prop in useOverlayOffset #6264

merged 3 commits into from Mar 10, 2022

Conversation

golota60
Copy link
Collaborator

@golota60 golota60 commented Mar 9, 2022

Fixes: #6250

useOverlayOffset was overriding user-defined offset prop. This passes the value explicitly to the helper hook

@golota60 golota60 requested a review from kyletsang March 9, 2022 21:01
@kyletsang
Copy link
Member

Can we add a test in useOverlayOffsetSpec?

@golota60
Copy link
Collaborator Author

golota60 commented Mar 9, 2022

getting some spooky errors - will fix in a sec

@golota60
Copy link
Collaborator Author

golota60 commented Mar 9, 2022

fixed, i thought i could arrange a scenario more similar to what's in the docs but i don't think that's possible

@golota60 golota60 changed the title fix: use offset prop in useOverlayOffset fix(useOverlayOffset): use offset prop in useOverlayOffset Mar 10, 2022
@golota60 golota60 merged commit e338818 into react-bootstrap:master Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kyletsang kyletsang kyletsang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

OverlayTrigger offset property has no effect
2 participants
@golota60 @kyletsang