New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Modal): render aria-describedby on the top level modal element #6282

Merged

kyletsang merged 1 commit into master from modal-aria-describedby

Mar 25, 2022

Member

kyletsang commented Mar 23, 2022

aria-describedby should be rendered on the element with the role="dialog"


          fix(Modal): render aria-describedby on the top level modal element

803d8ff

kyletsang requested a review from golota60

March 23, 2022 21:53

golota60 approved these changes

View reviewed changes

Collaborator

golota60 left a comment

👍 lgtm

kyletsang merged commit 93a8a0e into master

kyletsang deleted the modal-aria-describedby branch

March 25, 2022 16:05

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment