fix(deps): clean up @types deps list #6303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
golota60
approved these changes
Apr 18, 2022
|
When are we planning to merge this ? |
|
Can we please merge this soon? I am waiting on this for long |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves
@types/reactinto peer deps. This should be safe for npm 7 users when resolving peer dependencies because of the optional field inpeerDependenciesMeta. All users using TS would've installed a version of@types/reactanyway, so we shouldn't have problems here.For
invariant,prop-types, andwarning, those can be safely moved into devDeps because their types aren't exposed on the public d.ts files. They are just used internally within the implementation.