fix(TabPane): Omit Transition when prop is false

[headdu]

While using tabs I hit a small issue:

When passing the prop transition={false} to Tabs/TabPanes the fade class was always applied thus there's always a fade animation when we change Tabs.

I was able to reproduce this using the latest version of the lib and made a codesandbox

[kyletsang]

Thanks for the PR. I believe the issue here is that getTabTransitionComponent should actually return a different transition component rather than undefined because this ends up defaulting to Fade in the TabPane:

react-bootstrap/src/TabPane.tsx

Line 121 in e32c53d

transition: Transition = Fade,

The change should be made here:
https://github.com/react-bootstrap/react-bootstrap/blob/master/src/getTabTransitionComponent.ts

Add

import NoopTransition from '@restart/ui/NoopTransition';

then replace line 9 with

return transition ? Fade : NoopTransition;

See if this works out

[headdu]

Thank you for the pointers.

I did the changes you suggested and that seems to have done it as well 👍

[kyletsang]

Thanks!