Add containerPosition prop for ToastContainer #6316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
golota60
reviewed
May 2, 2022
src/ToastContainer.tsx
Outdated
| @@ -41,6 +42,13 @@ const propTypes = { | |||
| 'bottom-center', | |||
| 'bottom-end', | |||
| ]), | |||
|
|
|||
| /** | |||
| * By default the container is rendered with `position-absolute` utility class. Provide a string to use other `position-*` utility classes, or `false` to remove it. | |||
There was a problem hiding this comment.
or
falseto remove it.
Doesn't this accept only strings?
I think providing an empty string would achieve what you want here 😄 (also it could be a good idea to add a test for that)
There was a problem hiding this comment.
Oh forget to update this 🙈 I initially allow false to remove the position-* class, but I feel it is simpler to just use "static" or whatever utility class. Using an empty string should work as well, I'll update it.
kyletsang
approved these changes
May 3, 2022
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #6315.
I am unsure whether we should strictly limit the containerPosition values to position-* utility classes or allow any string, because it is possible to customize the utility classes.