Added support for portrait size ratios #6501
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regarding this issue: #6495, suggesting allowing ratios above 100% of the width to allow for portrait style presentation.
Currently, in the
toPercent()
function, any number above 1 converts to a percent, ensuring that width is always greater than or equal to height. Perhaps, for small numbers above 1 we could infer that the developer wants a portrait style layout. I've suggested 5 somewhat arbitrarily, but it seems absurdly small for a percent height/width ratio so seems safe to me. Suggestions?