Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(ToastContainer): apply containerPosition without position #6574

Merged
merged 1 commit into from Apr 7, 2023
Merged

fix(ToastContainer): apply containerPosition without position #6574

merged 1 commit into from Apr 7, 2023

Conversation

kyletsang
Copy link
Member

Fixes #6552

Allows setting containerPosition without needing to specify the position prop. Bootstrap added the position: absolute at some point to .toast-container, so we don't need to apply the containerPosition default value automatically anymore.

@kyletsang kyletsang merged commit 41ec134 into master Apr 7, 2023
8 of 13 checks passed
@kyletsang kyletsang deleted the toastcontainer-tweaks branch April 7, 2023 04:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jquense jquense jquense approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ToastContainer changes
2 participants
@kyletsang @jquense