Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: update dependencies #6587

Merged
merged 2 commits into from Apr 14, 2023
Merged

fix: update dependencies #6587

merged 2 commits into from Apr 14, 2023

Conversation

kyletsang
Copy link
Member

No description provided.

let noOp = () => {};

assert.doesNotThrow(() =>
ReactDOMServer.renderToString(
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I removed this test because it started failing due to react-restart/ui#72

It's throwing an error while rendering a portal during SSR. I think it's fine to remove the test tho, because in SSR, useWaitForDOMRef will return null and we won't render portals in SSR. This test doesn't exactly simulate a SSR environment properly.

@kyletsang kyletsang requested a review from jquense April 14, 2023 04:59
@kyletsang kyletsang merged commit 753dc53 into master Apr 14, 2023
12 of 13 checks passed
@kyletsang kyletsang deleted the bump-deps branch April 14, 2023 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants