New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(FormControl): ensures compatibility with @types/react@18.2.48 #6763
Merged
kyletsang
merged 1 commit into
react-bootstrap:master
from
giovannipiller:feature/update-types-react
Feb 9, 2024
Merged
fix(FormControl): ensures compatibility with @types/react@18.2.48 #6763
kyletsang
merged 1 commit into
react-bootstrap:master
from
giovannipiller:feature/update-types-react
Feb 9, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Do you have a reproducible example where I can test this fix on? |
giovannipiller
added a commit
to giovannipiller/react-bootstrap-pr-example-6763
that referenced
this pull request
Feb 5, 2024
The following code is broken on projects using const MyProps: FormControlProps = {
// placeholder has been removed from HTMLAttributes, therefore it's not accepted here
placeholder: "test",
}; You can checkout this simple project to reproduce: https://github.com/giovannipiller/react-bootstrap-pr-example-6763 |
kyletsang
approved these changes
Feb 9, 2024
Thanks |
This was referenced May 24, 2024
This was referenced May 24, 2024
This was referenced May 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like
@types/react
removed theplaceholder
attribute fromHTMLAttributes
.This may create inconsistencies when using
FormControl
.The proposed fix replaces it with a more explicit
InputHTMLAttributes
.