Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard input Tab + Shift escapes Modal's focus #6782

Open
3 tasks done
ankittrehan2000 opened this issue Mar 21, 2024 · 3 comments
Open
3 tasks done

Keyboard input Tab + Shift escapes Modal's focus #6782

ankittrehan2000 opened this issue Mar 21, 2024 · 3 comments
Labels

Comments

@ankittrehan2000
Copy link

ankittrehan2000 commented Mar 21, 2024

Prerequisites

Describe the bug

With the React Bootstrap modal open, attempt to move around with your keyboard using Shift + Tab. The elements from the background of the modal which should be out of focus start getting focused.

Expected behavior

Using Shift + Tab should keep the focus on the elements within the modal

To Reproduce

No response

Reproducible Example

https://codesandbox.io/p/sandbox/youthful-grothendieck-fzppl5

Screenshots

No response

What operating system(s) are you seeing the problem on?

No response

What browser(s) are you seeing the problem on?

No response

What version of React-Bootstrap are you using?

2.7.2

What version of Bootstrap are you using?

5.2.3

Additional context

No response

@kyletsang
Copy link
Member

Can you provide an updated sandbox link? The current link says "not found"

@ankittrehan2000
Copy link
Author

Hi can you please try it again. I realized it was in my drafts and couldn't be seen by someone else. Thanks!

Link https://codesandbox.io/p/sandbox/youthful-grothendieck-fzppl5

@kyletsang
Copy link
Member

When you shift tab, the base modal captures the key press and ends up focusing on the modal dialog div, although that's been set with a tabindex of -1:
https://github.com/react-restart/ui/blob/main/src/Modal.tsx#L383

Seems like this should be targeting the last focusable element within the modal though. @jquense was there a reason for focusing on the modal dialog div?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants