[fixed] Don't forward own props from <Position>

react-bootstrap · Nov 29, 2015 · c0b5890 · c0b5890
1 parent 9da2860
commit c0b5890
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Position.js b/src/Position.js
@@ -56,6 +56,8 @@ class Position extends React.Component {
     const {children, className, ...props} = this.props;
     const {positionLeft, positionTop, ...arrowPosition} = this.state;
 
+    Object.keys(Position.propTypes).forEach(key => delete props[key]);
+
     const child = React.Children.only(children);
     return cloneElement(
       child,

diff --git a/test/PositionSpec.js b/test/PositionSpec.js
@@ -216,5 +216,22 @@ describe('Position', function () {
     });
   });
 
+  it('should not forward own props to child', function () {
+    let spiedProps;
+    const Child = (props) => {
+      spiedProps = props;
+      return <div />;
+    };
+
+    ReactTestUtils.renderIntoDocument(
+      <Position target={() => null} childProp="foo">
+        <Child />
+      </Position>
+    );
+
+    expect(spiedProps.target).to.not.exist;
+    expect(spiedProps.childProp).to.equal('foo');
+  });
+
   // ToDo: add remaining tests
 });