Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rc-trigger Does not work in a Shadow DOM #301

Open
Jaggler3 opened this issue Jun 2, 2022 · 5 comments
Open

rc-trigger Does not work in a Shadow DOM #301

Jaggler3 opened this issue Jun 2, 2022 · 5 comments

Comments

@Jaggler3
Copy link

Jaggler3 commented Jun 2, 2022

Found this issue using the Ant Design package and traced it down to this dependency.

Reference: ant-design/ant-design#35897

Reproduce: https://codesandbox.io/s/ant-design-web-component-issues-lx7d2v?file=/index.js

Workaround is to pass this prop:

getDocument={documentElement && (() => documentElement)} // documentElement is a modified shadow-root

documentElement is retrieved using getRootNode() of the trigger element and also needs to add createElement to it because rc-trigger thinks it is a document object.

@davidenke
Copy link

@Jaggler3 your Sandbox is working for me; maybe the React version was < 17?
I can reproduce with your Sandbox, once downgraded to the latest 16.14 version. There was a very popular issue to the broken event stack, which has been fixed in 17.

@Jaggler3
Copy link
Author

Thank you for taking a look @davidenke
The React version specified in the CodeSandbox is 17.0.2. You were able to open & close the dropdowns in both the "In Web Component" and "Expected" sections the same way? (2nd click quickly closes and reopens the dropdown)

In case this is a browser issue, I am on Brave (chromium)

https://github.com/react-component/trigger/blob/master/src/index.tsx#L37
^ This is the function I traced it back to that I had replaced via prop. element.ownerDocument disregards the shadow DOM.

I just tried to downgrade the CodeSandbox to 16.14 and the dropdown won't open at all, that may be related to the issue you linked?

@davidenke
Copy link

@Jaggler3, yes, both version work for me on latest Chrome on macOS 12.4. After downgrading to React 16 I was able to reproduce the behaviour you described, so I shared my findings about the changes in the react event system :)

Nevertheless element.ownerDocument would behave the same, either within a shadow root or not - the question is if this is wanted, though. Most of the time I had issues with element.getRootNode() which delivers a reference to the closest shadow root instead of the document...

@Jaggler3
Copy link
Author

That makes sense. In my case I encountered the issue because it was injecting CSS into the ownerDocument which needs to be the shadow root because styles from the document don't trickle into it, but if that function is used for other things which need to return the document or relevant iframe even while in a shadow root I see where a problem could arise.

@yoyo837
Copy link
Member

yoyo837 commented Aug 23, 2023

Can you help to try the new package @rc-component/trigger?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants