Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DateRangePicker: DateInput right border is invisible #1964

Open
adamhenson opened this issue Apr 5, 2020 · 1 comment · May be fixed by #1965
Open

DateRangePicker: DateInput right border is invisible #1964

adamhenson opened this issue Apr 5, 2020 · 1 comment · May be fixed by #1965

Comments

@adamhenson
Copy link

react-dates version
e.g. react-dates@21.8.0

Describe the bug
Minor issue in that the right border is not visible. I was able to override this class to fix it, so not an urgent bug for me. I can submit a PR at some point if no one gets to this.

Source code (including props configuration)
Steps to reproduce the behavior:

<DateRangePicker
  startDate={this.state.startDate}
  startDateId="your_unique_start_date_id"
  endDate={this.state.endDate}
  endDateId="your_unique_end_date_id"
  onDatesChange={({ startDate, endDate }) => this.setState({ startDate, endDate })}
  focusedInput={this.state.focusedInput}
  onFocusChange={focusedInput => this.setState({ focusedInput })}
/>

Screenshots/Gifs
Screen Shot 2020-04-05 at 2 39 37 PM
Screen Shot 2020-04-05 at 2 39 57 PM

Desktop (please complete the following information):

  • OS: macOS 10.14.6
  • Browser: Chrome
  • Version: 80.0.3987.132

Fix
Would just need to update the block below to add box-sizing: border-box:
https://github.com/airbnb/react-dates/blob/480b9902d69e64e62a2ef5c2d3b5fc3adef94444/src/components/DateInput.jsx#L306-L324

@adamhenson
Copy link
Author

This isn't reproducible in Storybook, because of this Storybook specific style:
https://github.com/airbnb/react-dates/blob/480b9902d69e64e62a2ef5c2d3b5fc3adef94444/css/storybook.scss#L13-L15

@adamhenson adamhenson linked a pull request Apr 5, 2020 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant