ESM build #64
Open
ESM build #64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace old `dist/es/index.js` with `dist/index.mjs` that uses ESM syntax, and properly link to it via `module` and `exports`. Fixes react-dropzone#63
ArnaudBarre
reviewed
Sep 17, 2023
| "module": "dist/es/index.js", | ||
| "module": "src/index.js", | ||
| "exports": { | ||
| "import": "./dist/index.mjs", |
There was a problem hiding this comment.
You should provide types in the export map: https://publint.dev/rules#types_not_exported
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace old
dist/es/index.jswithdist/index.mjsthat uses ESM syntax, and properly link to it viamoduleandexports.Fixes #63
I also updated Webpack because otherwise I couldn't get it to run on modern Node.
What kind of change does this PR introduce?
Did you add tests for your changes?
If relevant, did you update the documentation?
Summary
See #63. This lets you
import accept from 'attr-accept'in ESM code.Does this PR introduce a breaking change?
If anyone directly imported
dist/es/index.js, it no longer exists. (It seems to be a holdover that made a "fake" ES module.)Other information
You can test the example in the README by making a file
test.mjsand then runningnode test.mjs. (The.mjsextension forces ESM mode.)