Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Critical 4.4.6 Bug: Module parse failed: Unexpected token (78:10) #736

Open
apwelsh opened this issue Oct 15, 2023 · 3 comments
Open

Critical 4.4.6 Bug: Module parse failed: Unexpected token (78:10) #736

apwelsh opened this issue Oct 15, 2023 · 3 comments

Comments

@apwelsh
Copy link

apwelsh commented Oct 15, 2023

Using react-data-grid, which depends on react-resizable, which depends on react-draggable
Since your update to 4.4.6, react-data-grid and react-sizable are now broken, and cannot be compiled into our projects.

Error reported is:

in ./node_modules/_react-draggable@4.4.6@react-draggable/build/cjs/Draggable.js
Module parse failed: Unexpected token (78:10)
You may need an appropriate loader to handle this file type.
| y: position.y,
| prevPropsPosition: {
| ...position
| }
| };

There is another bug report on the same issue, but it it not receiving any attention, so I opened up another with specifics on my issue

@micate
Copy link

micate commented Nov 15, 2023

Version 4.4.6 introduced multiple ... syntaxes in the build results, which caused incompatibility issues with lower version browsers.

image

image

image

@micate
Copy link

micate commented Nov 15, 2023

Although browsers that do not support the ... syntax are too old, this change should be a major version upgrade rather than a minor version change.

@apwelsh
Copy link
Author

apwelsh commented Nov 15, 2023

This was under the latest build of chromium. It's not a browser issue. In fact, react builds use the node compiler to implement all the latest features on nearly every browser, so again, that isn't the issue. This is simply bad code that breaks core react components that rely on this code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants