Fix dragging working not correct #2017
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The correct formula for calculating the container width is containerWidth === containerPadding * 2 + colWidth * cols + margin * (cols - 1)
The logic for calculating the positions of top and left in PR react-grid-layout#1323 is problematic. The compensation calculation for the containerPadding attribute should be placed in calcXY instead of being processed every time during dragging
|
Thx a lot!) |
|
Does this fix: #1877 |
|
Just tested this locally and it works like a charm. Fixes #1877 |
|
Ah better explained in: #2009 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fix the bug
What type of PR is this? (check all applicable)
Related Tickets & Documents
Fixes #2009
Mobile & Desktop Screenshots/Recordings
Added tests?
Added to documentation?