Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add named component export #10486

Merged
merged 1 commit into from
Jun 1, 2023
Merged

Add named component export #10486

merged 1 commit into from
Jun 1, 2023

Conversation

Moshyfawn
Copy link
Member

Closes: #10465

@codesandbox
Copy link

codesandbox bot commented Jun 1, 2023

This branch is running in CodeSandbox. Use the links below to review this PR faster.


CodeSandbox logoCodeSandbox logo  Open in CodeSandbox Web Editor | VS Code | VS Code Insiders | Preview

@github-actions
Copy link
Contributor

github-actions bot commented Jun 1, 2023

Size Change: 0 B

Total Size: 19.6 kB

ℹ️ View Unchanged
Filename Size
dist/index.cjs.js 9.74 kB
dist/index.umd.js 9.82 kB

compressed-size-action

@Moshyfawn
Copy link
Member Author

Moshyfawn commented Jun 1, 2023

This PR fixes the export issue, @bluebill1049. You can try it in this codesandbox success branch

@bluebill1049
Copy link
Member

oh really???

@bluebill1049
Copy link
Member

image

@bluebill1049
Copy link
Member

This PR fixes the export issue, @bluebill1049. You can try it in this codesandbox success branch

Project not found, but I trust you!

@bluebill1049 bluebill1049 merged commit 8b3c76b into master Jun 1, 2023
7 checks passed
@bluebill1049 bluebill1049 deleted the fix/mjs-export-issue branch June 1, 2023 22:52
@Moshyfawn
Copy link
Member Author

I can't say I'm 💯 sure

This PR fixes the export issue, @bluebill1049. You can try it in this codesandbox success branch

Project not found, but I trust you!

Ooof, not sure why, but should work now (directly copied the link instead of using their "share" feature)

@bluebill1049
Copy link
Member

Going to publish it now since it impacts so many users. 🚀

@Moshyfawn
Copy link
Member Author

Going to publish it now since it impacts so many users. 🚀

🔥 sounds good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

issue: Can't import the named export 'Fragment' from non EcmaScript module (only default export is available)
2 participants