[v7-React-Native] Validations don't work correctly with hermes enabled (Android only)

[ahce]

Describe the bug
When hermes is enabled, the validations don't work, if hermes is disabled works normally.

To Reproduce
Steps to reproduce the behavior:

1. clone this repo
2. open terminal
3. yarn install / npm install
4. yarn start / npm start
5. open new terminal
6. yarn android / npm run android
7. press submit button and check validations
8. type in the text input and check validations
9. disable hermes
10. try again from step 4 to 7

Code sample link

• repo

Expected behavior
Same behavior with or without hermes

Smartphone

• Device: Emulator
• OS: Android 10

Environment

Tech	Version
react	16.13.1
react-native	0.63.4
react-hook-form	7.3.6

[bluebill1049]

Try to reproduce it here: https://snack.expo.io/@bluebill1049/react-hook-form-v7---controller.

[ahce]

Try to reproduce it here: https://snack.expo.io/@bluebill1049/react-hook-form-v7---controller.

Expo doesn't have this issue because expo doesn't enable hermes.

[bluebill1049]

what difference is that going to make? I am not familiar with hermes.

[bluebill1049]

I would copy what's in my expo and export it to your project and test it out yourself.

[ahce]

what difference is that going to make? I am not familiar with hermes.

Hermes is a JS engine, provides some improvements, perfomance, small app and others.
I don't know it's failing with react-hook-form

[ahce]

I would copy what's in my expo and export it to your project and test it out yourself.

It also has the issue.
The submit count doesn't increment, without hermes works.

[bluebill1049]

I don't even see a submit count in my example.

[ahce]

It is a detail to detect the issue.
I added version 6 with switch to change (with v6 hermes works).

Please download the repo.

[bluebill1049]

I am having a hard time getting it working react-native... can you reproduce that in expo app? or expo doesn't support hermes?

[ahce]

I am having a hard time getting it working react-native... can you reproduce that in expo app? or expo doesn't support hermes?

Expo doesn't use hermes.
The issue could be similar to this

I uploaded the apks:

• apk with hermes
• apk without hermes

Also I updated the repo with form state info.

[bluebill1049]

Can u try to install a 'Proxy' ployfill? Apk doesn't really help me to debug the issue.

[bluebill1049]

it's on and it's working for me.

Screen.Recording.2021-05-02.at.8.54.12.am.mp4

[ahce]

This issue only happens on Android, iOS doesn't enable hermes.

[bluebill1049]

-_- please be more specific

[ahce]

proxy-polyfill solved this issue!
I updated the sample repo!

[bluebill1049]

it's on ios as welll

[bluebill1049]

so it's PROXY???

[ahce]

so it's PROXY???

Yes!!!

[bluebill1049]

so it's PROXY???

Yes!!!

AWESOME! this needs to go into FAQ.

[ahce]

it's on ios as welll

Yes, but since react-native >= 0.64, the sample repo uses 0.63.4

[bluebill1049]

updated, thanks for the help and investigation ahce.

[GfxKai]

Proxy is now enabled by default from Hermes v0.7, so this step is no longer necessary https://github.com/facebook/hermes/releases/tag/v0.7.0

[bluebill1049]

Proxy is now enabled by default from Hermes v0.7, so this step is no longer necessary https://github.com/facebook/hermes/releases/tag/v0.7.0

we have removed proxy, so react native will share the same perf enhancement as web. will update the doc or feel free to send us a pr as well.