We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
IconBaseProps accepts the children prop meaning JSX like
<FaApple> <span>Hello world</span> </FaApple>
would be valid. However, the children will not be displayed.
Either props.children should be rendered as a child, or the component should not accept children as a prop.
https://gist.github.com/jasperfirecai2/8a7171243f61067e94fa7c40f7ac1ce3
4.11.0
No response
Allowing children to be rendered would allow license attribution to be added to icons in jsx code.
The text was updated successfully, but these errors were encountered:
Hi, I can fix this issue can you please assign this to me? Thanks
Sorry, something went wrong.
Will this be addressed?
No branches or pull requests
Describe the bug
IconBaseProps accepts the children prop meaning JSX like
would be valid. However, the children will not be displayed.
Expected behavior
Either props.children should be rendered as a child, or the component should not accept children as a prop.
Minimal sample repository URL
https://gist.github.com/jasperfirecai2/8a7171243f61067e94fa7c40f7ac1ce3
Steps To Reproduce
Package version
4.11.0
Relevant log output
No response
Additional context
Allowing children to be rendered would allow license attribution to be added to icons in jsx code.
The text was updated successfully, but these errors were encountered: