fix: align mock of multiMerge with actual behavior #733
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krizzu
reviewed
Jan 11, 2022
| asMock.__INTERNAL_MOCK_STORAGE__[key] = | ||
| oldValue != null | ||
| ? JSON.stringify(merge(JSON.parse(oldValue), JSON.parse(value))) | ||
| : value; |
There was a problem hiding this comment.
I think this should also be stringified?
There was a problem hiding this comment.
It's already stringified. We actually parse it in the old code:
async-storage/jest/async-storage-mock.js
Line 98 in bcaf152
I've moved parsing until we actually need it, so we no longer need to stringify in the else-clause.
krizzu
approved these changes
Jan 11, 2022
|
🎉 This PR is included in version 1.15.15 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Resolves #731.
Test Plan
n/a