Fix assembleAndroidTest builds

[mrbrentkelly]

Overview

Fixes an issue when building and running instrumented tests (e.g. Detox) for a React Native project on Android, the following build error was occurring:

Execution failed for task ':react-native-community_netinfo:mergeExtDexDebugAndroidTest'.
> Could not resolve all files for configuration ':react-native-community_netinfo:debugAndroidTestRuntimeClasspath'.
   > Failed to transform core-1.6.0-alpha03.aar (androidx.core:core:1.6.0-alpha03) to match attributes {artifactType=android-dex, dexing-enable-desugaring=false, dexing-is-debuggable=true, dexing-min-sdk=23, org.gradle.category=library, org.gradle.dependency.bundling=external, org.gradle.libraryelements=aar, org.gradle.status=release, org.gradle.usage=java-runtime}.

If an Android library uses Java 8 language features then it must declare compileOptions in its build.gradle.

...each module that uses Java 8 language features (either in its source code or through dependencies), update the module's build.gradle file, as shown below:

https://developer.android.com/studio/write/java8-support#supported_features

Fix is simple to add Java 8 compileOptions to the build.gradle. I've seen and fixed similar issues in other projects as well:

negativetwelve/react-native-ux-cam#104
snowplow/snowplow-react-native-tracker#117

Test Plan

Made the change locally in my projects node_modules, then rebuilt the app, and it was successful 🎉 .

[mikehardy]

irony: android gradle plugin 4.2.0 defaults to java 8 so this is unnecessary for builds using current stable build tool chains as of...this week. But everyone won't upgrade immediately of course.

I don't see any reason why this wouldn't work - it's a best practice anyway. Interesting it hasn't popped up before actually?

[mrbrentkelly]

Yeah I only tend to see it in projects that have instrumented Android tests, so perhaps not enough projects are writing tests 😆

[mrbrentkelly]

Just following up on this. Anything else you need me to change or answer before this PR is merged?

[mikehardy]

Nope I think we're just waiting on @matt-oakes to whack the merge button, until then patch-package 🤷

[mikehardy]

This is still needed for some old projects, no reason not to merge, and I can merge now

[matt-oakes]

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀