fixed warnings 'new NativeEventEmitter() was called with a non-null a… #487
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rgument without the required addListener and removeListener methods' on react-native 0.65 and android platform
mikehardy
requested changes
Aug 20, 2021
There was a problem hiding this comment.
I think the iOS side will need the same stubs? For example:
RCT_EXPORT_METHOD(addListener : (NSString *)eventName) {
// Keep: Required for RN built in Event Emitter Calls.
}
RCT_EXPORT_METHOD(removeListeners : (NSInteger)count) {
// Keep: Required for RN built in Event Emitter Calls.
}in RNCNetInfo.m
|
@mikehardy, I didn't notice any warnings on ios side, but will try to add this changes in PR |
… for compatibility rn-0.65
|
@mikehardy , added requested changes for IOS, but not sure if it added in correct place, can you check it ? |
matt-oakes
approved these changes
Aug 23, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Aug 24, 2021
## [6.0.1](v6.0.0...v6.0.1) (2021-08-24) ### Bug Fixes * Ensure warnings are not shown on React Native 0.65 ([#487](#487) by [@lubomyr](https://github.com/lubomyr)) ([ac0ed65](ac0ed65)) * **android:** isConnected is incorrect for wifi networks only the app has access to ([#443](#443) by [@eliaslecomte](https://github.com/eliaslecomte)) ([7084771](7084771))
|
🎉 This PR is included in version 6.0.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
mieszko4
added a commit
to mieszko4/react-native-zoom-us
that referenced
this pull request
Oct 4, 2021
willxy
added a commit
to paxproinc/react-native-background-downloader
that referenced
this pull request
Jan 25, 2023
- warnings at startup: - new NativeEventEmitter called with non-null argument without the required addListener method - new NativeEventEmitter called with non-null argument without the required removeListeners method - related to RN 0.65 - ref: - https://reactnative.dev/docs/native-modules-android#sending-events-to-javascript - react-native-netinfo/react-native-netinfo#486 - react-native-netinfo/react-native-netinfo#487 - https://github.com/react-native-netinfo/react-native-netinfo/blob/master/CHANGELOG.md#601-2021-08-24 - react-native-webrtc/react-native-webrtc#1072 - facebook/react-native@114be1d - RevenueCat/react-native-purchases#339
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…rgument without the required addListener and removeListener methods' on react-native 0.65 and android platform
Overview
This PR fix warns
WARN new NativeEventEmitter() was called with a non-null argument without the required addListener method.
WARN new NativeEventEmitter() was called with a non-null argument without the required removeListeners method.
on Android platform with react-native 0.65 (0.65.0, 0.65.1, and probably next higher versions)
Issue: #486
Test Plan