Remove methods that break event listeners on RN 0.65.1 #493
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@xHeinrich @mikehardy Am I correct in thinking that this will cause the warning to re-appear, but will fix the issues in the linked issue? |
|
I think having the stubs for android silence the warning, while on ios they are not needed. That's un intuitive but seems to match the reported behavior |
|
I'm leaning towards merge+release as there is definite reported breakage with the listeners and worst case they will only cause a warning if missing, while further triage happens. I'll do the same (merge + release) in the absence of dissent, in the next couple hours |
mikehardy
added
the
pending merge
mikehardy
referenced
this pull request
in react-native-device-info/react-native-device-info
Sep 3, 2021
…opmatibility Fixes #1288
mikehardy
referenced
this pull request
in zoontek/react-native-localize
Sep 3, 2021
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Sep 3, 2021
## [6.0.2](v6.0.1...v6.0.2) (2021-09-03) ### Bug Fixes * **ios:** remove iOS listener stubs added for RN0.65 compat, they caused a regression ([#493](#493)) ([a52b0a5](a52b0a5))
|
🎉 This PR is included in version 6.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Dec 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #492