fix(jcenter): remove jcenter #500

Bibazavr · 2021-09-28T12:35:44Z

Overview

Builds will no longer be able to resolve artifacts from JCenter after February 1st, 2022 because jcenter servers shut down

so, I remove jcenter and update react-native (since 0.65.1 they don't use jcenter)

fixed example - don't work, because one '/../' was deleted (fab577d)
fixed eslint configures
fixed jest configures

Fixes #499

Test Plan

Just start up example and make sure everything is ok:)

Builds will no longer be able to resolve artifacts from JCenter after February 1st, 2022 because jcenter servers shut down so, I remove jcenter and update react-native (since 0.65.1 they don't use jcenter) + fixed example - don't work, because one '/../' was deleted (fab577d) + fixed eslint configures + fixed jest configures BREAKING CHANGE: remove jcenter update React Native to 0.65.1 minSdkVersion=16 Refs: react-native-netinfo#499

mikehardy

Wow! Upgrading the example app is a lot of work, this is a difficult task but is really needed, thanks for posting this.

I had some specific questions about a few of the choices made while you did the upgrade but make no mistake - this is really cool, and I'm excited to see the example app updated and jcenter removed.

I will note that jcenter has specifically said they'll keep the repo up indefinitely, so this is not an urgent matter, but at the same time removing it is the right thing to do. The upgrade of react-native is the really useful thing IMHO :-). See the updates on https://jfrog.com/blog/into-the-sunset-bintray-jcenter-gocenter-and-chartcenter/ for backup on my assertion jcenter will stay available

jest.config.js

package.json

src/internal/nativeInterface.ts

android/gradle.properties

example/android/app/build.gradle

Bibazavr · 2021-09-29T06:28:20Z

@mikehardy, What about "Resolve conversation"? You will resolve them after reading or i should do this?:o

I hope my English is not so terrible - i try my best:D

mikehardy · 2021-09-29T11:31:46Z

Your English is really good actually, no worries there 💪

If I started them I prefer to resolve, that's how I know I've verified the resolution on re-review

It's only 630am here though so I need some coffee first ☕

upgrade react-native-web because gets error's on tests

…n=16

example/android/build.gradle

mikehardy

This looks pretty good in general now - thank you for backing out all the breaking stuff. The 275,000 downloads the module gets a week will appreciate not having a breaking change :-)

I notice you added a move of the java classes, and also there was a buildTools version thing I committed a fix for that made me think you've never run the example on android, as it should not work.

Can you run this locally on web + ios + android and verify it's working? I suspect after you've moved the example java classes you need an AndroidManifest change as well for the new package name?

fix: - applicationId for react-native run-android. - update podfile for new react-native - refactoring react-native.config.js for better developer experience

Bibazavr · 2021-10-01T10:51:38Z

This looks pretty good in general now - thank you for backing out all the breaking stuff. The 275,000 downloads the module gets a week will appreciate not having a breaking change :-)

Of course, you right:)

Can you run this locally on web + ios + android and verify it's working? I suspect after you've moved the example java classes you need an AndroidManifest change as well for the new package name?

I moved files because package was not satisfying directory

screens

was:

now:

I was run android but by using `./gradlew build && ./gradlew installDebug`:o

Today i figured why react-native run-android not works (it was before me):

applicationId was wrong into example/android/app/build.gradle
and add some stuff to react-native.config.js:

Now react-native run-android works perfectly:3

But I could not do same with react-native run-ios:c (but build from xcode works fine)

And proof of work:

mikehardy

I reproduced your success with android example (nice!) and I got iOS example working in the last commit I just added on to this. Could you pull my changes and make sure everything still works for you?

Bibazavr · 2021-10-04T05:12:22Z

I could not test on weekend. Today i launched example and it looks like ios simulator scarry of something:D

2021-10-04.08.05.11.mov

Maybe its my PC broke

mikehardy · 2021-10-04T16:27:44Z

I am going to say that is your PC not working right somehow hahaha - it looks to me like the bundler is fast-refreshing over and over (giving you that little top-bar appearance/disappearance which makes the content move). I'm certain the iOS was working (and the android also worked for me), so if it ran at all I am going to call it a win. It did not work before, so it is certainly better.

mikehardy · 2021-10-04T16:28:50Z

My last test on this one is that I want to test the built module from this change with an older react-native (I'll probably do 0.60 so I don't have to manually link...) just to make sure it works. It should but who knows - I don't want to accidentally release a breaking change as I have done that before and it is a real emergency when it happens. No fun at all

mikehardy · 2021-10-18T14:03:41Z

Haven't had time yet but to be specific about the test I want to see in case someone has time:

What I want to do is take the result of building react-native-netinfo from that PR (yarn pack or similar) and use that locally in a sample app from a npx react-native init --version 0.60.6 to make sure it works

Bibazavr · 2021-10-22T05:35:46Z

@mikehardy, it works but i tested only android and useNetInfo hook

https://github.com/Bibazavr/netinfooldrntest

mikehardy · 2021-10-22T11:49:49Z

Oh hey that's a really big help! I can pull that and check ios. This has been nagging at me without enough time, seriously thanks for helping out

mikehardy · 2021-10-22T14:09:20Z

Checks out on ios -

and "today I learned" that react-native 0.60 cannot even be compiled by Xcode-12.5 (much less Xcode 13 or 13.1 about to come out...) you have to use Xcode 12.4 with it. I happen to have those laying around as side-by-side installs but I can't believe people are still using those. Starting in April 2022 (6 months from now) Xcode 13 will be required for App Store submission and only react-native 0.62+ will compile on Xcode 13

mikehardy

Good to go

## [6.0.3](v6.0.2...v6.0.3) (2021-10-22) ### Bug Fixes * **android, jcenter:** remove jcenter dependency / update example ([#500](#500)) ([94c5398](94c5398))

matt-oakes · 2021-10-22T14:21:13Z

🎉 This PR is included in version 6.0.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Bibazavr requested a review from matt-oakes as a code owner September 28, 2021 12:35

mikehardy requested changes Sep 28, 2021

View reviewed changes

jest.config.js Show resolved Hide resolved

package.json Outdated Show resolved Hide resolved

src/internal/nativeInterface.ts Show resolved Hide resolved

android/gradle.properties Outdated Show resolved Hide resolved

example/android/app/build.gradle Show resolved Hide resolved

mikehardy mentioned this pull request Sep 29, 2021

NativeEventEmitter types are incorrect, code needs forward-port #502

Open

mikehardy added awaiting info changes requested labels Sep 29, 2021

Bibazavr added 3 commits September 30, 2021 11:03

test(jest-expo): fix jest.config.js

43738ed

upgrade react-native-web because gets error's on tests

refactor(android): move example source into dir suitable package name

eecaadb

return peerDependencies for "react-native": ">=0.59" and minSdkVersio…

6720e7a

…n=16

Bibazavr requested a review from mikehardy September 30, 2021 08:42

mikehardy reviewed Sep 30, 2021

View reviewed changes

example/android/build.gradle Outdated Show resolved Hide resolved

pin android buildTools to api30, add ndkVersion pin

b0f3397

mikehardy reviewed Sep 30, 2021

View reviewed changes

chore: improve react-native.config.js

da642b0

fix: - applicationId for react-native run-android. - update podfile for new react-native - refactoring react-native.config.js for better developer experience

Bibazavr requested a review from mikehardy October 1, 2021 10:51

fix(ios, example): ios example works now

15ab806

mikehardy approved these changes Oct 1, 2021

View reviewed changes

mikehardy removed the changes requested label Oct 1, 2021

Bibazavr requested a review from mikehardy October 4, 2021 05:13

mikehardy mentioned this pull request Oct 18, 2021

[feat] Add 5g cellular type #436

Merged

mikehardy approved these changes Oct 22, 2021

View reviewed changes

mikehardy merged commit 94c5398 into react-native-netinfo:master Oct 22, 2021

github-actions bot pushed a commit that referenced this pull request Oct 22, 2021

chore(release): 6.0.3 [skip ci]

dc9ffac

## [6.0.3](v6.0.2...v6.0.3) (2021-10-22) ### Bug Fixes * **android, jcenter:** remove jcenter dependency / update example ([#500](#500)) ([94c5398](94c5398))

matt-oakes added the released label Oct 22, 2021

mikehardy mentioned this pull request Oct 22, 2021

jcenter shut down soon #499

Closed

This was referenced Oct 29, 2021

fix(jcenter): remove jcenter react-native-webview/react-native-webview#2178

Merged

Potential breaking change react-native-webview/react-native-webview#2185

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix(jcenter): remove jcenter #500

fix(jcenter): remove jcenter #500

Bibazavr commented Sep 28, 2021 •

edited by mikehardy

mikehardy left a comment

Bibazavr commented Sep 29, 2021

mikehardy commented Sep 29, 2021

mikehardy left a comment

Bibazavr commented Oct 1, 2021

mikehardy left a comment

Bibazavr commented Oct 4, 2021

mikehardy commented Oct 4, 2021

mikehardy commented Oct 4, 2021

mikehardy commented Oct 18, 2021

Bibazavr commented Oct 22, 2021

mikehardy commented Oct 22, 2021

mikehardy commented Oct 22, 2021

mikehardy left a comment

matt-oakes commented Oct 22, 2021

fix(jcenter): remove jcenter #500

fix(jcenter): remove jcenter #500

Conversation

Bibazavr commented Sep 28, 2021 • edited by mikehardy

Overview

Test Plan

mikehardy left a comment

Choose a reason for hiding this comment

Bibazavr commented Sep 29, 2021

mikehardy commented Sep 29, 2021

mikehardy left a comment

Choose a reason for hiding this comment

Bibazavr commented Oct 1, 2021

mikehardy left a comment

Choose a reason for hiding this comment

Bibazavr commented Oct 4, 2021

mikehardy commented Oct 4, 2021

mikehardy commented Oct 4, 2021

mikehardy commented Oct 18, 2021

Bibazavr commented Oct 22, 2021

mikehardy commented Oct 22, 2021

mikehardy commented Oct 22, 2021

mikehardy left a comment

Choose a reason for hiding this comment

matt-oakes commented Oct 22, 2021

Bibazavr commented Sep 28, 2021 •

edited by mikehardy