Use ConnectivityManager instead of ConnectivityManagerCompat #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ReactNativeNetInfo_minSdkVersion=16 https://developer.android.com/training/monitoring-device-state/connectivity-status-type#java Note: If your app needs to support Android 4.0 (API level 15) and lower, use ConnectivityManagerCompat.isActiveNetworkMetered instead of ConnectivityManager.isActiveNetworkMetered().
mikehardy
requested changes
Oct 22, 2021
There was a problem hiding this comment.
Nice!
I verified that there is no case where react-native for android will be targetting API 15 or below, as it has always been a minSdkVersion of 16: https://github.com/facebook/react-native/blame/5017b86b525e3ef6023f0f8a88e6fd1cf98024e0/local-cli/templates/HelloWorld/android/app/build.gradle
I had some comments on further cleaning and null safety - curious for your thoughts there
Finally - I'm going to put this in the queue behind #500 which is about to merge, just in case they both perturbed the build.gradle, this PR should take the conflict since that has been outstanding longer
android/src/main/java/com/reactnativecommunity/netinfo/ConnectivityReceiver.java
Outdated
Show resolved
Hide resolved
no Co-authored-by: Mike Hardy <github@mikehardy.net>
…ivityReceiver.java Check for null connectivity manager before dereferencing
mikehardy
approved these changes
Oct 22, 2021
github-actions bot
pushed a commit
that referenced
this pull request
Oct 22, 2021
## [6.0.4](v6.0.3...v6.0.4) (2021-10-22) ### Bug Fixes * **android:** use ConnectivityManager directly, drop androidx dependency ([#509](#509)) ([2569f56](2569f56))
|
🎉 This PR is included in version 6.0.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ReactNativeNetInfo_minSdkVersion=16
https://developer.android.com/training/monitoring-device-state/connectivity-status-type#java
Note: If your app needs to support Android 4.0 (API level 15) and lower, use ConnectivityManagerCompat.isActiveNetworkMetered instead of ConnectivityManager.isActiveNetworkMetered().
Overview
Test Plan