New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(windows, crash): try/catch fetching network profile, new windows example app #511
Conversation
tero-paananen
commented
Oct 29, 2021
•
edited by mikehardy
edited by mikehardy
- Fixes Windows with device's SIM card fails #454 Windows with device's SIM card fails
- react-native-windows 0.65.6 in use
- Example app ported to use react-native-windows 0.65.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wow - this is great, thank you for taking the time to update the windows port while fixing this issue.
I have no problem with this approach, and after some more review I can likely approve - I'm just curious if you've seen this and ever attempted it? https://github.com/microsoft/react-native-test-app/
It just showed up on my radar a week or two ago and I haven't had the time to test it, but it appears like it might automate this whole process and take away all manual labor in the future for multi-platform maintenance which would be an absolutely incredible win if reality matched theory
I have ever noticed https://github.com/microsoft/react-native-test-app/ i will check that app later |
Hey thanks for mentioning that project. First time I am hearing about it. I am curious about it and will check it out. I'd love to have better all app sample project! |
Since the temporary key was regenerated, and there is no easy way to verify this thru code PR. Otherwise all looks great to me! 👍 |
I played with react-native-test-app yesterday as part of re-vamping the example app in https://github.com/invertase/react-native-apple-authentication which had gone out of date. I'm not sure if I'm doing something wrong or not but I had a 10GB node_modules folder and everything was sloooooowwww So for me I am very very curious about that project and intend to follow it (and help it if possible) but it's still "in the lab" testing right now, I can't say my experience qualified it for use just yet until I know more. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This LGTM - is there any chance this is a breaking change for windows users?
I have no problem with breaking changes if it is one, I just want to make 100% that if it is breaking I do a semver major and we document exactly what steps module users should take to forward-port if so
🎉 This PR is included in version 6.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |