fix(ios, 5g): do not use 5g symbols until iOS14.1 #525
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
added
the
pending merge
|
Hey @marcoskoch / @furlanrapha / @luisnaranjo733 / @MateusAndrade - you were all interested in 5G symbols in react-native-netinfo - could someone give this a look? I think we'll have crashes on iOS < 14.1 without this availability check, according to the docs and Xcode's warnings. Does it look right? If I don't hear from anyone I'll merge it in a day or so. Cheers! |
verified with previous code that the conditional logic terminated with the previous else prior, this one was added by the Xcode available guard refactor but is not needed
mikehardy
removed
awaiting info
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
## [7.1.1](v7.1.0...v7.1.1) (2021-11-17) ### Bug Fixes * **ios, 5g:** do not use 5g symbols until iOS14.1 ([#525](#525)) ([932cd83](932cd83))
|
🎉 This PR is included in version 7.1.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
While I was working in the module I saw the warning that we were touching symbols only available on iOS14.1 with no guard, that will crash on older iOS
Test Plan
Ask for testers from #436 and #417