fix(jest, mock): addEventListener mock returns a function to match API #529
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mikehardy
approved these changes
Nov 17, 2021
There was a problem hiding this comment.
Indeed you are right https://github.com/react-native-netinfo/react-native-netinfo#usage - great catch
mikehardy
changed the title
github-actions bot
pushed a commit
that referenced
this pull request
Nov 17, 2021
## [7.1.2](v7.1.1...v7.1.2) (2021-11-17) ### Bug Fixes * **jest, mock:** addEventListener returns a function to match API ([#529](#529)) ([82ca2ad](82ca2ad))
|
🎉 This PR is included in version 7.1.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
NetInfo.addEventListener()returnsunsubscribefunction from actual api, but corresponding jest mock returns nothing. Jest mock should also return a mocked function.Test plan
Dependent on existing test suite