New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(web, isConnected): Return actual connection state even if network type is 'unknown' #544
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I worry about altering the isConnected type, as mentioned in the comment tagged on that line, this would be breaking and reverse an intentional change made earlier this year
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
just docs now as commented with specifics, then good to go
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks excellent, CI checks then 🚀
## [7.1.3](v7.1.2...v7.1.3) (2021-11-29) ### Bug Fixes * **web, isConnected:** Return actual connection state even if network type is 'unknown' ([#544](#544)) ([36d6dc9](36d6dc9))
🎉 This PR is included in version 7.1.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
Whenever connection type is 'unknown', library returns isConnected=false instead of actual connection state. Unknown network type does not necessarily mean that we have no internet connection. For instance, Electron apps and apps running on chromebooks with instant tethering enabled return 'unknown' network type even when connected to the internet.
Reasoning
We should return the correct connection state even for 'unknown' connection type
Test Plan
Fixes #450