New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(android): try async state fetch as stale state workaround #547
fix(android): try async state fetch as stale state workaround #547
Conversation
queued for review + testing but me work queue is ridiculous at the moment, no promises on time. I'm listening though in case others have results |
Haven't tried android 12, (still on 11) but I can confirm this builds + fixes the issue on my device |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me but I haven't had a chance to test sadly. I have deep respect for @Titozzz as a source of truth though, and will be available for mopup reviews+merges in case for some reason this blows up. @cristianoccazinsp you have really been a champion here, along with the rest of the crew like @Willham12 really trying to root out this problem. My sincere appreciation for that: thank you
Awesome! With Android, it's impossible to tell whether or not something will work for all devices, so it's a matter of testing and patiently waiting. |
🎉 This PR is included in version 7.1.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
@mikehardy looks like I missed a null check (damn Java).
PR to fix it will be coming up shortly today. PR: #550 |
"The billion dollar mistake" (re: null in general) |
Overview
Attempt to fix #542 and #537 without fully undoing #510 changes.
The change aims to address the issue #510 fixes (not calling the network methods in the callback), but preserving the original implementation that uses data from the callbacks.
Could use some review and thoughts @mikehardy and @Willham12
Test Plan
Manually tested on a Google Pixel 5 (Android 12)
Commands that helped debug:
adb shell dumpsys deviceidle force-idle
adb shell dumpsys deviceidle unforce
adb shell input keyevent KEYCODE_WAKEUP