fix: android: make sure initial network value is not stale on app startup #553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Make sure we use a final reference to the instance variables in case they are modified in another callback while being used.
…ing the app with no connectivity reports it as none instead of unknown. - Replace Runnable with lambda as suggested by linter
mikehardy
approved these changes
Dec 20, 2021
There was a problem hiding this comment.
Hmm not sure about the unclean commit history but I can certainly squash it away.
git reset --hard && git fetch upstream && rebase upstream/master would blow it out (assuming upstream is what you call the remote for main repo), then cherry-pick just your commit
I wouldn't do that now - I'll merge and squash as the diff itself is clean but that's what I'd do if my tree was in this state prior to pushing
Anyway, LGTM :-), even the intersectionality with #548 I think - thanks!
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2021
## [7.1.7](v7.1.6...v7.1.7) (2021-12-20) ### Bug Fixes * **android:** populate network value during initial module startup ([#553](#553)) ([c05080f](c05080f))
|
🎉 This PR is included in version 7.1.7 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
When the app is started with no connectivity (e.g., wifi off or airplane mode), the library currently reports
unknownandconnected = truevalues because network listeners are never called when there's no network info, so all default values are read.After this, we now try to properly set the initial network values on register (similar to what the old broadcast received does and was not carried over to the new implementation.
I've also taken the chance to replace the
Runnablewith a lambda as suggested by the linter.P.S.: no idea why old commits were carried over, I'm sure I branched from master.
Test Plan
Tested on Google Pixel 5 (Android 12, RN 0.66.3)
Steps to test:
NetInfo.fetch()on mount or similar, type should benoneTest again, but now without airplane mode on startup, to make sure the app still reports connectivity when first started if available.