fix(windows): refactor implementation to avoid crashes #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add support for more properties.
mikehardy
requested changes
Jan 21, 2022
|
Just a note that checking this out locally and building it (with commit from #565 picked locally to run things) - everything seems to work for me. I have no wifi on my test windows VM and it just returns null for those entries FWIW |
mikehardy
approved these changes
Jan 25, 2022
mikehardy
added
the
pending merge
mikehardy
changed the title
mikehardy
removed
the
pending merge
github-actions bot
pushed a commit
that referenced
this pull request
Jan 25, 2022
## [7.1.8](v7.1.7...v7.1.8) (2022-01-25) ### Bug Fixes * **windows:** refactor implementation to avoid crashes ([#564](#564)) ([cc4bfa3](cc4bfa3))
|
🎉 This PR is included in version 7.1.8 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
The existing Windows implementation shared state across multiple threads without proper synchronization and allowed asynchronous NetworkStatusChanged events to access invalid memory during teardown of the module. The shared state wasn't really necessary, so I've streamlined the code to avoid it altogether.
Manual serialization to JSValue has been replaced with the newer macro-based automation. I've also added support for a few netinfo properties that were missing on Windows, though they require the "wiFiControl" capability be specified in the appxmanifest.
Test Plan
Ethernet connection:
WiFi connection:
