fix(windows): fix race condition in WiFi connection details feature #568
Conversation
…nrt's fire_and_forget
…detection into asynchronous operation
|
Hi there @jfkm69 - with sincere apologies, and I'm not sure I've ever seen this in a module before! - but 2 people were working on a windows item at once and there has been a massive collision between this PR and the just merged #564 This is really unfortunate, but in order for this PR to be considered it will have to be based off the new/current master branch commits |
…to ensure network events are handled in order
jfkm69
changed the title
jfkm69
changed the title
|
Hi @mikehardy, I merged to the latest version of master and updated the PR to fix a few issues that came up as a result of #564. Thanks to @bbowman for the review. |
There was a problem hiding this comment.
I've checked this out and I can attest it builds and runs successfully in my environment with seemingly correct results but I did not reproduce the original fault and thus can't commit on the actual fix.
Curious what @bbowman thinks as their review was ace! Happy to merge + release with consensus
Co-authored-by: Mike Hardy <github@mikehardy.net>
…status argument to use const ref
|
Just chiming in to say that I really appreciate the review + collaboration as it is way past my rusty college-courses-then-did-not-use-it C++ skills. I'm watching and still happy to hit the big green "merge" (and release) button as soon as there is consensus. Appears all comments are addressed, so just curious for a look from @aschultz then off we go I think. Cheers |
There was a problem hiding this comment.
I pulled it locally to check after the last commits/approvals here - noticed that the windows msbuild.binlog wasn't gitignore'd, so I added that but there are few things more minor than a .gitignore change, hopefully that's okay! Helps keep my local git tree clean vs dirty when testing at least, for the future. Going to merge and it should auto release. Thanks!
mikehardy
changed the title
## [7.1.11](v7.1.10...v7.1.11) (2022-02-08) ### Bug Fixes * **windows:** fix race condition in WiFi connection details feature ([#568](#568)) ([0cd8132](0cd8132))
|
🎉 This PR is included in version 7.1.11 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
The main objective of this PR was to add support for getting Wi-Fi properties on the Windows platform, however, thanks to this PR(#564) we now have access to an asynchronous method to accommodate the retrieval of Wi-Fi properties. However, the current implementation does not keep track of the Network Status requests and suffers from a race condition that will allow unordered delivery of Network Info Details because it simply returns the result of the current request without acknowledging that it's predecessor has been completed. Lastly, we added support for the
requestedInterfaceproperty and removed access todetailsproperties that were unavailable for the given connection type.Test Plan
Getting Wi-Fi properties from
requestedInterface:Connection history:
Before:
After:
