fix(android): count native listeners / correctly disable listener if count == 0 #569
Conversation
There was a problem hiding this comment.
This looks obviously correct and matches my mental model of what was needed after I read the related upstream react-native code when you logged the issue yesterday. Thanks a bunch for posting this
Separately - with regard to your comment on Kotlin use and how it might make things match the react-native programming model better, that does sound nice. I'm not personally motivated to do it but if you wanted to post a java-->kotlin PR we could certainly merge it, kotlin is the future for android development and there are numerous popular modules using it so that would work for me. Only thing I can think of there is making sure the kotlin version is pulled from ext block where possible so consuming libraries may specify it and not end up with multiple / conflicting runtime libs - I believe thats possible?
mikehardy
added
the
pending merge
mikehardy
changed the title
mikehardy
removed
the
pending merge
## [7.1.9](v7.1.8...v7.1.9) (2022-01-26) ### Bug Fixes * **android:** count native listeners / correctly disable listener if count == 0 ([#569](#569)) ([5ae16f6](5ae16f6))
|
🎉 This PR is included in version 7.1.9 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Overview
Fixes #567
Test Plan
The changed behavior is not observable, unless you watch the events send over the RN bridge
Note:
It would be better to also remove the android network listeners if there are no listeners in RN. I also develop other RN modules and there we use kotlin, coroutines and flows which allows us to implement RN modules in a reactive way without the overhead of managing threads, subscriptions, events and callbacks.